Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web vitals #952

Merged
merged 10 commits into from
Jul 6, 2020
Merged

Web vitals #952

merged 10 commits into from
Jul 6, 2020

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Jul 4, 2020

Fixes #944

@max-ostapenko max-ostapenko self-assigned this Jul 4, 2020
@rviscomi
Copy link
Member

rviscomi commented Jul 4, 2020

Curious to hear @bazzadp's thoughts on the new browserify and babel dependencies.

@rviscomi rviscomi requested a review from tunetheweb July 4, 2020 04:59
@tunetheweb
Copy link
Member

Curious to hear @bazzadp's thoughts on the new browserify and babel dependencies.

Not loving it to be honest. We’ve a very light JS implementation at the moment and this seems a lot to add just for this. Do we really need them? This suggests not.

@tunetheweb
Copy link
Member

Appreciate this is only needed to compile the script and actually added to the site so not massively concerned if we’re prefer to keep them in. But seems to could just download the pre-compiled version and remove the dependency.

src/templates/base.html Outdated Show resolved Hide resolved
@max-ostapenko
Copy link
Contributor Author

max-ostapenko commented Jul 4, 2020

@bazzadp I was concerned regarding adding unpkg.com to CSP, is it fine?
Alternatively, we could install web-vitals npm package and manually copy compiled browser js to static/js.

@rviscomi
Copy link
Member

rviscomi commented Jul 4, 2020

I think I prefer the npm and static/js approach over unpkg, and both of those options over saving a local copy that will inevitably go stale.

@tunetheweb
Copy link
Member

tunetheweb commented Jul 4, 2020

Oh definitely want it local rather than loaded from third-party.

It’s a fair comment about it going stale. But it still requires a command to generate the new version - so how will we know when to run that? And what’s the difference between running that periodically and just downloading it from unpkg to our own static dir periodically?

I would have thought compile option was more for if you wanted to compile it into other code you were writing rather than the straight compile we’re doing here?

But look, at end of the day it’s a couple more dependencies in build, not in the website, so could be persuaded to just go with it as is. But so let me know thoughts on above questions I asked.

@max-ostapenko
Copy link
Contributor Author

Maybe this would be minimal effort solution:

fs
  .copy(
    './node_modules/web-vitals/dist/web-vitals.es5.umd.min.js',
    './static/js/web-vitals.js',
  )
  .catch(err => console.error(err));

triggered on npm run generate?

@tunetheweb
Copy link
Member

I like that idea!

@tunetheweb
Copy link
Member

Also means it will be run by the GitHub Action which will do a fresh npm install each time and only commit it when it changes. So will always be up to date.

src/tools/generate/web-vitals.js Outdated Show resolved Hide resolved
src/tools/generate/web-vitals.js Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

tunetheweb commented Jul 4, 2020

Max, can you also add yourself to the src/config/2020.json file in the developers teams?

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (with two minor nits) - thanks for working on this!

src/config/2020.json Outdated Show resolved Hide resolved
src/package.json Outdated Show resolved Hide resolved
src/templates/base.html Outdated Show resolved Hide resolved
src/templates/base.html Outdated Show resolved Hide resolved
@max-ostapenko
Copy link
Contributor Author

I get Google advertising errors on public website:
Refused to load the image 'https://www.google.pt/ads/ga-audiences?v=1&aip=1&t=sr&_r=4&tid=UA-22381566-3&cid=722833102.1592150741&jid=307643168&_v=j83&z=1389390864&slf_rd=1&random=3377659529' because it violates the following Content Security Policy directive: "img-src 'self' www.google-analytics.com www.googletagmanager.com stats.g.doubleclick.net *.githubusercontent.com *.google.com ssl.gstatic.com data:".

Should we fix it or switch it off?

@tunetheweb
Copy link
Member

Yeah I get the same as in Ireland so use google.ie. Unfortunately there is no easy way to whitelist every Google domain in a CSP.

Not sure how to turn this off to be honest. Is it a setting in GA or GTM?

@max-ostapenko
Copy link
Contributor Author

gtag('set', 'allow_google_signals', false );
https://developers.google.com/analytics/devguides/collection/gtagjs/display-features

@tunetheweb
Copy link
Member

gtag('set', 'allow_google_signals', false );
https://developers.google.com/analytics/devguides/collection/gtagjs/display-features

I'd be a fan of that, as better for privacy.

Guessing that's the same as removing from Google Analytics admin? Unfortunately I only have read-only access so we'll need @rviscomi to confirm if it's on there and whether to disable in there instead. If it's disabled in there already, then I say we add above. If it's not enabled and we're still getting this error, then can try above. Did you test it and it removes the error?

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually had my morning cup of tea and spotted some more things. Sorry about the drip feeding of the feedback like this.

Comment on lines 36 to 37
webVitals.getLCP(sendWebVitalsGAEvents, true);
webVitals.getCLS(sendWebVitalsGAEvents, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want true for these? The documentation suggests not:

This could be useful if, for example, you want to report the current LCP candidate as the page is loading, or you want to report layout shifts (and the current CLS value) as users are interacting with the page. In general, though, using reportAllChanges is not needed (or recommended).

@rviscomi you'll know these Web Vitals better than us two I imagine so any opinion here?

Suggested change
webVitals.getLCP(sendWebVitalsGAEvents, true);
webVitals.getCLS(sendWebVitalsGAEvents, true);
webVitals.getLCP(sendWebVitalsGAEvents);
webVitals.getCLS(sendWebVitalsGAEvents);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that it would benefit in having overview over frequency:
Total events per Event Label and Page
and total value:
Event Value per Event Label and Page

Of course it comes with a cost of sending a sequence of same metric event requests (I've seen up to 3 events of same type locally).

If we set reportAllChanges=false, then the event is sent before navigating away, once per page:
Event Value per Event Label and Page
OR cumullative over all pageviews:
Event Value per Page

Do you think frequency will make sense?

P.S. Hope you'll share collected insights.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw some LCP events that happen after rendering is finished (fires together with FID) may have 0 delta.
Don't know if it gives you some performance issue hint, but I'd like your feedback if it makes sense to collect such events.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have one metric reported per page load to keep the analytics simple. Reporting non-final values isn't recommended as @bazzadp pointed out and I think this means we will need to report the value rather than the delta.

cc @philipwalton

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you.
But I'd still prefer to keep metric.delta as a event value. It's equal to metric.value in the first event, but in case there are several events sent - aggregated metric.delta will report correct value, but aggregated metric.value will inflate total event value in report.
And there will be no need to change it, if you decide to collect all events in future.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes LGTM!

I'd prefer to have one metric reported per page load to keep the analytics simple. Reporting non-final values isn't recommended as @bazzadp pointed out

@rviscomi FYI, CLS is the exception to this, see this explanation in the README:

Important: unlike other metrics, CLS continues to monitor changes for the entire lifespan of the page—including if the user returns to the page after it's been hidden/backgrounded. However, since browsers often will not fire additional callbacks once the user has backgrounded a page, onReport is always called when the page's visibility state changes to hidden. As a result, the onReport function might be called multiple times during the same page load (see Reporting only the delta of changes for how to manage this).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, so we'd have to aggregate event values by SUM when looking at session-level stats.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to consider is that GA has a 500 hit per session limit. Firing a lot of events on a single page can quickly get you to that limit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, if you're using the reportAllChanges feature and sending a hit to GA with every callback. If you're not using reportAllChanges then the max number of hits you will send is three plus the number of times the tab is backgrounded in the same session.

I just did a quick check on my site, and over the last 28 days, the 99th percentile of "Web Vitals" events in a single session is 5 (the 99.9th percentile is 11), so probably nothing to worry about.

src/tools/generate/generate_js.js Show resolved Hide resolved
@rviscomi rviscomi added this to TODO in 2020 via automation Jul 5, 2020
@rviscomi rviscomi added this to the 2020 Platform Development milestone Jul 5, 2020
@rviscomi rviscomi moved this from TODO to In progress in 2020 Jul 5, 2020
@tunetheweb tunetheweb added development Building the Almanac tech stack performance Issues related to site performance labels Jul 5, 2020
@tunetheweb tunetheweb merged commit 74e9170 into HTTPArchive:main Jul 6, 2020
2020 automation moved this from In progress to Done Jul 6, 2020
@tunetheweb
Copy link
Member

Merged! Thanks @max-ostapenko !

jrharalson added a commit to jrharalson/almanac.httparchive.org that referenced this pull request Jul 24, 2020
* Add Results and Queries buttons to each chapter (HTTPArchive#728)

* Add links for results and queries

* Remove incorrect alt attributes

* Smaller bottom marginat end of chapter content

* Optimised images with calibre/image-actions

* Increment page.css version as contains breaking changes

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix incorrect image in CSS chapter. (HTTPArchive#730)

* Fix incorrect image

* Optimised images with calibre/image-actions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Improved index sidebar (HTTPArchive#732)

* Fixed index in desktop view

* Highlight the current section being read in the index

* Code cleanups + add Methodology

* Use active style that was already defined

* Better way of ensuring current element is in the viewport

* Only set sticky when upgrading and also support prefers-reduced-motion

* Move index highlighter up above interactive visuals

* Add vendor prefix for Safari v12

* Code cleanup

* Add back incorrectly removed overflow

* Code refactor after review from @rviscomi

* Remove index-scroller element and revert smooth scroller

* Fix more code review issues

* Extra comment on scrollIntoView

* Add test for index (HTTPArchive#734)

* Stop showing scrollbars when not needed for code blocks (HTTPArchive#735)

* Slightly better icons (HTTPArchive#739)

* Slightly better icons

* Optimised images with calibre/image-actions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Translation of ecommerce chapter to Japanese (HTTPArchive#741)

* Translation of ecommerce chapter to Japanese

* delete line break

* Fixed review

* update alankent and samdutton's PR

* delete unnecessary file

* fix review

* Regenerated chapters

* Ref links for chapter headings and figures (HTTPArchive#737)

* Add reference link before chapter headings and figures

* Fix markup errors

* Add links to Methodology ad Accessibility Statement

* Add example chapter

* aAdd missing div for Acc statement

* Optimised images with calibre/image-actions

* Add link to authors section

* Add classes to anchor_links

* Support old link formats

* Spacing fixes

* Change link.png to SVG

* Remove need for two classes

* Add aria-hidden to link icon

* Ensure no deletion of attributes

* Review feedback

* Fix changes no longer required

* Remove link icon on mobile

* Fix figures for some chapters

* Tweak spacing a little

* Move margin-left to better location

* Remove style no longer required

* Change chapter_links to <section> for conssitency

* Fit mis-numbered image in Font chapter

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Regenerated chapters

* Translation of cms chapter to Japanese (HTTPArchive#736)

* Translation of cms chapter to Japanese

* I have fixed review points

* Regenerated chapters

* Translation of SEO chapter (HTTPArchive#742)

* translation of SEO chapter

* Apply suggestions from code review

Added &nbsp; before % sign

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Apply suggestions from code review

Co-Authored-By: Boris Schapira <borisschapira@gmail.com>

* Update src/content/fr/2019/seo.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/fr/2019/seo.md

Co-Authored-By: Boris Schapira <borisschapira@gmail.com>

* Apply suggestions from code review

Modification of many reviews

Co-Authored-By: Boris Schapira <borisschapira@gmail.com>
Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* modifications after the team reviews

* other modifications

* ymschaap bio

* Non-breaking space before "%"

* Typofix

* Using back-tilts instead of french quotes

* Typofix

* Better description for AMP

* labels of stats on featured chapter

* No "alternate" in the original verbatin

* Fix back-tilts

* Update src/content/fr/2019/seo.md

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/fr/2019/seo.md

Minor change

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Update src/content/fr/2019/seo.md

Organization schema type correct

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Boris Schapira <borisschapira@gmail.com>

* Regenerated chapters

* Missing escape (HTTPArchive#744)

* Misc HTML fixes (HTTPArchive#745)

* Regenerated chapters

* Featured chapters fr (HTTPArchive#746)

* Markup chapter

* CMS chapter

* Caching chapter

* Resource Hints chapter + small fixes

* Missing space

* Some fixing

* Bio hyperlinks (HTTPArchive#747)

* Fix bios

* Typos

* Missing escape (HTTPArchive#748)

* Fix errors in Japanese featured chapters and enable ecommerce (HTTPArchive#749)

* Translation of featured_chapters to Japanese (HTTPArchive#750)

* Translation of featured_chapters to Japanese

* fix review

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Translation of base.html  to Japanese (HTTPArchive#751)

* Translation of base.html  to Japanese

* Fixup URLs in bios

* More bio fixes

Co-authored-by: Barry <barry@tunetheweb.com>

* Translation of base_chapter to Japanese (HTTPArchive#754)

* Translation of base_chapter to Japanese

* Translation of index.html to Japanese

* fix review

* Fix unintended escape (HTTPArchive#756)

* Fonts japanese translation (HTTPArchive#755)

* Translation of fonts chapter to Japanese

* fix web almanac

* Adding changes for @ksakae1216 due to permission issues

* Featured Chapters from @ksakae1216

* Fix markup bug for fonts chapter

* Active fonts featured chapters

Co-authored-by: Barry <barry@tunetheweb.com>

* Regenerated chapters

* Don't translate Web Almanac and HTTP Archive (HTTPArchive#758)

* Don't translate Web Almanac and HTTP Archive

* fix review

* Regenerated chapters

* Translate "and" and show correct localized chapter name (HTTPArchive#757)

* Translate "and" and show correct localized chapter name

* Update src/templates/ja/2019/base.html

* Allow Written by to be before or after for Japanese

* Remove lastmod from sitemap (HTTPArchive#753)

* Regenerated chapters

* Automatically remove any trailing slashes (HTTPArchive#726)

* Automatically remove any trailing slashes

* Handle trailing slashes on odd pages

* Better comments

* Remove sitemap.xml redirect as not required

* Move accessibility check to route

* Better way of handling accessibility statement

* Remove old accessibillity route

* Query strings for Accessibility Statement

* Allow up to 200% font zooming for Accessibility (HTTPArchive#731)

* Relative font sizes and selective margin and padding

* Fix skip link

* Better way to do grid on mobile

* Fit footer on mobile (tab order and grid)

* Fix long line which breaks font zooming

* Fix font comment

* Fix typos

* FR translation for a11y chapter (HTTPArchive#759)

* Creation of FR translation for a11y chapter

Related to HTTPArchive#539

* Fix some descriptions (vertical/horizontal)

* Add kbd tag to tab text

* Add non-breaking space before percentages

* Fix some URLs

* Fix line number

Co-Authored-By: Barry Pollard <barry_pollard@hotmail.com>

* Accessibility chapter FR translation

* FR translation of bio a11y

* Escape quotes on Abigail's bio

* Minor fixes

* Improve wording

* Web -> web + gender inclusive developpers

* More inclusive (gender)

* microtypo

* Improve meaning

* More inclusive

* Moved Boris updates to chapter summary

+ microtypo fixes

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Boris SCHAPIRA <borisschapira@gmail.com>

* Regenerated chapters

* Misc fixes for accessibility translations (HTTPArchive#760)

* Translation of resource-hints chapter to Japanese (HTTPArchive#762)

* Translation of resource-hints chapter to Japanese

* translate featured_chapters

* fix review

* Regenerated chapters

* Stop the intersection observer menus on mobile (HTTPArchive#761)

* Stop the intersection observer menus on mobile

* Hide section highlighter on mobile and tablet

* Enable Resource Hints in Ja Featured Chapters (HTTPArchive#763)

* Media japanese translation (HTTPArchive#764)

* Translation of media chapter to Japanese

* fix P10

* fix review.

* Generate chapters (HTTPArchive#766)

* Featured chapters methodology japanese translation (HTTPArchive#770)

* Translation of media chapter to Japanese

* fix P10

* Translation of featured_chapters and methodology to Japanese

* Fix review

* fix second review

* Stop overriding username as think that is breaking the action (HTTPArchive#771)

* Update date on ja Methodologoy as a test (HTTPArchive#772)

* Generate chapters action fix (HTTPArchive#773)

* Stop overriding username as think that is breaking the action

* Add necessary config back

* Gen chaps (HTTPArchive#774)

* Update date on ja Methodologoy as a test

* Update date

* Gen chaps (HTTPArchive#775)

* Update date on ja Methodologoy as a test

* Update date

* Update date on home page

* Contributors table accessibility japanese translation (HTTPArchive#776)

* Translation of contributors.html, table_of_contents.html, accessibility_statement.html to Japanese

* Add website

* Generate chapters (HTTPArchive#777)

* Update date on ja Methodologoy as a test

* Update date

* Update date on home page

* Gen chapters

* Translation of javascript chapter to Japanese (HTTPArchive#785)

* Translation of javascript chapter to Japanese

* Fix review

* Update lastmod dates (HTTPArchive#784)

* Update FR SEO last mod date

* Better script to update timestamps

* Update timestamps

* Fix bad dates

* Remove hours and mins

* Add lastmod back to sitemap

* Add support for the old grid spec for IE (HTTPArchive#786)

* Add support for the old grid spec for IE

* Fix typo

* Generate chapters action fix (HTTPArchive#783)

* Stop overriding username as think that is breaking the action

* Add necessary config back

* New Pull Workflow

* Open PR on merge

* Don't cache redirects and errors (HTTPArchive#779)

* Don't cache redirects and errors

* Update src/main.py

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Update src/main.py

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Update HTTP/3 links (HTTPArchive#787)

* Update HTTP/3 links

* Fix typo

* Update labels and projects (HTTPArchive#789)

* Generate Chapters (HTTPArchive#788)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix bad japanese link (HTTPArchive#790)

* Generate Chapters (HTTPArchive#791)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix GitHub Action labels and projets (HTTPArchive#792)

* Generate Chapters Action fix (HTTPArchive#793)

* Fix GitHub Action labels and projets

* Fix typo

* Fix bad link (HTTPArchive#794)

* Generate Chapters (HTTPArchive#795)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* SVG icons system HTTPArchive#740 (HTTPArchive#781)

* Improved the button that toggles the mobile menu.

* The custom select uses now a pseudo elements as a chevron.
The menu toggle button is now consistent and inherits the main menu & select hover styles as well.

* Contributor rectangles background is now a base64 encoded SVG

* HTTPArchive, Twitter, GitHub and website icons are now SVG symbols

* Bar chart, comment & sql icons added.

* Update src/templates/base/2019/base_chapter.html

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Update src/templates/base/2019/base_chapter.html

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Update src/templates/base/2019/base_chapter.html

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Move aria-label attribute to parent

* Fix Firefox accessibility alerts

* Fix dropdown menu in IE11

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry <barry@tunetheweb.com>

* Bump CSS version numbers (HTTPArchive#800)

* Remove project from chapter generate GitHub action (HTTPArchive#805)

* Update date on ja Methodologoy as a test

* Update date

* Update date on home page

* Gen chapters

* Remove project

* Regen chaps

* Add CSS incrementer GitHub action (HTTPArchive#802)

* Add CSS incrementer GitHub action

* Remove project

* Add year dir

* Handle both base and year htmls

* Fench Organization translation (HTTPArchive#807)

* Generate Chapters (HTTPArchive#808)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix some bad markup spotted in French SEO chapter (HTTPArchive#811)

* Generate Chapters (HTTPArchive#812)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Restrict Image Compression Action to pull requests from this repo (HTTPArchive#816)

* Time to Interactive is NOT the time until a page is interactive (HTTPArchive#782)

* Time to Interactive is NOT the time until a page is interactive
See https://boris.schapira.dev/2019/05/measuring-interactivity-time-to-interactive/\#disambiguation for a full explanation.

* Update src/content/en/2019/mobile-web.md

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Generate Chapters (HTTPArchive#818)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Translation TTL Mobile (HTTPArchive#820)

* Generate Chapters (HTTPArchive#821)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Ebook for the Almanac - take 2 (HTTPArchive#817)

* Committing what I have on the generator so far.

* Tidied up some more stuff.

* Generated the pdf using weasy.

* Tweaked some stuff and added weasyprint to the requirements.

* Move to general base templates and add Japanese version

* Update README on ebook generation steps

* Author improvements

* Fix meta data

* Handle cross references and misc other fixes

* Add Intro, Foreword, Methodology and Contribitors

* Improved contributors plus some other fixes

* Fix typos and add back images for weasyprint

* Regenerate ebook

* Misc Fixes

* Add ebook link to ToC

* Remove bios from JSON config as now in base.html

* Sorted Contributors

* Fix figure links

* Regen ebook

* Remove Figure link underlines in print mode

* Update src/main.py

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Update src/main.py

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Update src/templates/base/2019/table_of_contents.html

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Review feedback

* Review feedback

* Review feedback

* Review feedback

* Fix typo

* Fix typo

* Fix Foreword title

Co-authored-by: Mike Geyser <mikegeyser@gmail.com>
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Generate Chapters (HTTPArchive#822)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix typos in Increment CSS Actions (HTTPArchive#824)

* Track ebook link clicks (HTTPArchive#825)

* Stop links opening in a new tab (HTTPArchive#827)

* Fix image labels for Compression Chapter (HTTPArchive#828)

* Fix image labels for Compression Chapter

* Optimised images with calibre/image-actions

* Regen ebook

* Regen books

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Translation of base.html to Japanese (HTTPArchive#829)

* Translation of base.html to Japanese

* fixed review

* Generate Chapters (HTTPArchive#830)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix <table> markup (HTTPArchive#831)

* Fix <table> markup

* Fix typos

* Generate Chapters (HTTPArchive#832)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* More table and figure markup cleanup (HTTPArchive#834)

* Fix <table> markup

* Fix typos

* Table and fig cleanups

* Generate Chapters (HTTPArchive#835)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* One more table markup fix for security chapter (HTTPArchive#836)

* Fix <table> markup

* Fix typos

* Table and fig cleanups

* One mor bad table markup

* Correct digit to respect figure (HTTPArchive#839)

* Generate Chapters (HTTPArchive#840)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix JavaScript Chapter errors (HTTPArchive#841)

* Fr Translation – Mobile Web chapter (HTTPArchive#838)

* Fr Translation

* Video print fallbacks (cf. HTTPArchive#837)

* Mobile Web FR added to Featured chapters

* My own readproofing

* Using French chevrons

* `lang="en"` on "Javascript bloat score"

* Missing non-break spaces

* `lang="en"` on Layout Instability API

* Missing apostrophe

* Using `<code>` around hexa-defined colors

* Missing space

* Update src/content/fr/2019/mobile-web.md

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Fix repetition

* `lang="en"` on The Cost of JavaScript

* ":" instead of ";"

* `lang="en"` sur Layout Instability

* "@"

* Better description

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Generate Chapters (HTTPArchive#842)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Video print fallbacks plus other Mobile Web chapter fixes (HTTPArchive#837)

* Add print fallbacks for video embeds

* Japanese alt text

* Bug fixes from French review

* Increment CSS version numbers (HTTPArchive#843)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate Chapters (HTTPArchive#844)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate Chapters (HTTPArchive#845)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Switch eBook PDF generation from WeasyPrint to Prince (HTTPArchive#833)

* Move to EJS templates for consistency and to fix missing author pictures

* Add Prince Support (inc fixing figure aria labels)

* Add YouTube fallback

* Fix table in Japanese chapter

* move from WeasyPrint to Prince

* Update README.md

* Remove unnecessary change

* Update statement for PDF accessibility

* Regen PDFs

* Fix typos

* Fix spacing

* Review feedback

* Review feedback

* Review feedback

* Misc fixes

* Make contributors line up

* Fix text wrapping issue in Methodology section

* Prince supports SVG social media icons

* Add print support in case we ever want to print a physical copy

* Remove link underlines in print mode

* Add footnotes and left/right pages

* Fix typos

* templates/base/2019/base_ebook.html

* Avoid hanging headers

* Review feedback

* Increment CSS version numbers (HTTPArchive#846)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate Chapters (HTTPArchive#847)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix tap targets of social media icons (HTTPArchive#848)

* Increment CSS version numbers (HTTPArchive#849)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Perf improvements to mobile-web chapter (HTTPArchive#852)

* Merge Generate Chapters and Increment CSS GitHub actions (HTTPArchive#851)

* Compress all images using TinyPNG (HTTPArchive#853)

* Compress all images using TinyPNG

* Optimised images with calibre/image-actions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Translation of fig2-description to Japanese (HTTPArchive#858)

* Translation of fig2-description to Japanese

* delete unnecessary file

* Translation about PDF to Japanese (HTTPArchive#859)

* Translation about PDF to Japanese

* Fix review

* Generate Chapters (HTTPArchive#860)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate Chapters (HTTPArchive#861)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Colour contrast image fixes (HTTPArchive#863)

* Colours that meet 4.5 contrast ratio

* Fix typos

* Grayscale changes

* Fix typo

* More grayscale fixes

* Add code elements

* Clean up SVG

* Update image based on @OBTo's feedback

* New version of image

* Generate Chapters (HTTPArchive#864)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Increment JS version file on change - same as we do for CSS (HTTPArchive#862)

* Add a "Show Description" button (HTTPArchive#857)

* Add "Show Description" button to figures

* Add figure ids to "Show Description" buttons

* Misc typos

* Generate Chapters (HTTPArchive#865)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Regenerate book (HTTPArchive#866)

* Accessibility statement improvements (HTTPArchive#868)

* Add dynamic sidebar and date to Accessibility Statement

* Whitespace fixes

* Add background colour to options (which will be ignored!) to address accessibility fail in Firefox

* Update src/templates/ja/2019/accessibility_statement.html

Co-authored-by: Sakae Kotaro <ksakae1216@gmail.com>

Co-authored-by: Sakae Kotaro <ksakae1216@gmail.com>

* Generate Chapters (HTTPArchive#869)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Formatting changes to ToC page (HTTPArchive#870)

* Formatting changes to ToC page

* Change ebook_exist function to check for pdf and not template

* Generate Chapters (HTTPArchive#871)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Move generate script language and year config to JSON (HTTPArchive#867)

* Improve Ebook generation

* Generalise generate chapters for multi-years

* Make ebook generation dynamic

* Code cleanup

* Fix colour on Language selector as causing Firefox issue (HTTPArchive#872)

* Generate Chapters (HTTPArchive#873)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Regenerate ebooks (HTTPArchive#874)

* Update project README for 2020 (HTTPArchive#879)

* Update README.md

* Update README.md

* Master branch rename (HTTPArchive#881)

* Fix typo in CSS stylesheet

* Change all references of master to main

* Generate Chapters (HTTPArchive#882)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Replace whitelist (HTTPArchive#883)

* Replace whitelist

* Generate chapters and ebook

* Review feedback

* Generate Chapters (HTTPArchive#889)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add noindex meta tag for on-canonical URLs (HTTPArchive#888)

* Tidy up breadcrumbs for multi-year support (HTTPArchive#890)

* Tidy up breadcrumbs for multi-year support

* Move index breadcrumb back to where it original was.

* Generate Chapters (HTTPArchive#891)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Create README.md

* Create README.md

* 2020 chapter issue template

cc @OBTo

* Update 2020-chapter.md

* Update 2020-chapter.md

* Delete 2020-chapter.md

the bulk of the chapter issues are created, removing the template to discourage people from filing new issues with it unnecessarily
if needed again we can copy an existing issue

cc @OBTo

* Update README.md

* 2020 year support and basic 2020 landing page (HTTPArchive#893)

* Generate Chapters (HTTPArchive#891)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Misc fixes

* Turn off 2020 by default

* Optimised images with calibre/image-actions

* Fix mobile drop down

* Hide items for 2020 for now

* Fix selectors on desktop

* Revert to grey for 2020

* Remove year drop down from Accessibility Statement

* Better 2020 image

* Merge Language and Year JavaScript

* Review feedback

* Fix typos

* Better way to hide nav items for 2020

* Handle hero image better cross years

* Remove uneeded if statement

* Rename block

* Add sorting to switchers

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate Chapters (HTTPArchive#925)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Sort contributors (HTTPArchive#928)

* CSS logo (HTTPArchive#930)

* Custom CSS logo
HTTPArchive#567

* Fix horizontal scroll on the index page due to #maincontent vw unit width
HTTPArchive#567

* DRY

* Keep self.organization() for ebooks

* Each template has its own logo.

* No longer needed.

* Generate Chapters (HTTPArchive#934)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix index font zoom (HTTPArchive#931)

* Fix index font zoom

* Add px fallback to rem font-size

* Remove unnecessary README

* Generate Chapters (HTTPArchive#935)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Windows ebook generation (HTTPArchive#936)

* Make ebook command work on windows

* Revert path changed (wasn't an issue) and add double quotes round arguments instead

* Allow the server to be backgrounded with optional command line argument (HTTPArchive#932)

* GitHub linter (HTTPArchive#939)

* Add super linter

* Remove import errors from linter

* Temporarily remove MD files

* Fix typo

* Disable import errors and CSS linting

* Another attempt at ignoring imports

* Ignore know dependencies

* Re-enable CSS

* Add CSS linting

* Tune CSS rules

* CSS tweaks

* CSS tweaks

* More CSS Tweaks

* More CSS Tweaks

* CSS Tweaks

* Fix CSS

* Add back some CSS rules

* CSS Tweaks

* More CSS Tweaks

* Fixup CSS, Add MD

* Markdown fixes

* MArkdown fixes

* Fix markdown issues

* Fix markup issues

* Fix markdown issues

* Add Standard JS

* Remove Standard as not configurable

* Review feedback

* Fix comment

* Run action on push ot pull

* aImprove comments

* Improved comments

* Improved comments

* Generate Chapters (HTTPArchive#940)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixed typo in js featured snippet (HTTPArchive#941)

* fix: typo in js featured snippet

* fix(featured_chapter/js): explanation of 3P and 1P

* fix(blockquote):add line-height to make it easier to read

* Generate Chapters (HTTPArchive#942)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update Flask version to fix a deprecation warning (HTTPArchive#958)

* Update Flask version to fix a deprecation warning

* Remove version number of flask to keep it up to date

* Remove version number of gunicorn to keep it up to date

* Fix incorrcet colour for ToC highlighter (HTTPArchive#960)

* Generate Chapters (HTTPArchive#961)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add ibnesayeed in 2020.json (HTTPArchive#963)

* Add ibnesayeed in 2020.json

* Sort records lexographically by name

* Make header/footer padding consistent (HTTPArchive#951)

* Make header/footer padding consistent HTTPArchive#947

- update footer styles to use 60px same as header content for non-mobile viewports

* - fix lint error with multi line

* - make footer content flow consistent with header for internal and home page
- update styles for footer to align center for mobile and tablet viewports

* update 2020.json

- add dsadhanala to contributors list

* Generate Chapters (HTTPArchive#964)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Clean up inline styles (HTTPArchive#965)

* Generate Chapters (HTTPArchive#966)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Web vitals (HTTPArchive#952)

* added browserify and tracking function

* compiled js bundle

* TTFB tracking

* web-vitals over npm copy

* added max-ostapenko

* cleanup

* compact event value code

* console log removed

* reportAllChanges=true

* Add Docker-based development environment (HTTPArchive#956)

* Add Docker-based development environment

* Change network interface to make container service accessible

* Update develpment README with Docker instructions

* Remove a RegEx deprecation warning

* Add container exit instruction in the README

* Pin Python version to 3 in Dockerfile

* Use consistent build arg names in Dockerfile

* Rephrase server kill instruction

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Add Google Cloud SDK on demand

* Document supported build args

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Clean-up old code, and update version numbers (HTTPArchive#959)

* Clean-up old code, and update version numbers

* Regenerate chapters

* Remove inline styles from chapters

* Review feedback

* Only modify changed or added files - not deleted ones (HTTPArchive#967)

* 2020 landing page content (HTTPArchive#950)

* 2020 landing page (coming soon)

* TODO: translate landing pages

* "Join the team"

* reuse existing translations

* disable 2020

* re-enable 2020

* Generate Chapters (HTTPArchive#968)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix spacing issues in header on tablet (HTTPArchive#970)

* Fix spacing issues in header on tablet

* Remove old px based margin as no longer required

* Generate Chapters (HTTPArchive#971)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Hero image with year as text (HTTPArchive#954)

* Custom CSS logo
HTTPArchive#567

* DRY

* Keep self.organization() for ebooks

* No longer needed.

* The year is now SVG HTTPArchive#894

* Linter issues.

* bold is same as 700 weight. Trigger Lint Code Base check.

* Remove no longer needed assets.

* Magic number to make the image centered when < 900px

* IE11 SVG height fix.

* Add a margin between the main intro grid areas.

* Update the hero image canvas

* Run tinypng

* Fallback font-size

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Generate Chapters (HTTPArchive#972)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix font size for logo year (HTTPArchive#973)

* Fix font size for logo year

* Slight tweak for Firefox

* Generate Chapters (HTTPArchive#974)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Ebook generation (HTTPArchive#975)

* Ebook generation

* Regen books

* Remove offset for image whihc is now no longer required (HTTPArchive#976)

* Fix typo (scoppe instead of scope) (HTTPArchive#978)

* Fix typo (HTTPArchive#980)

* Generate Chapters (HTTPArchive#981)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Compression chapter fix K to k (HTTPArchive#982)

* Fix typo

* Small k for thousands

* Generate Chapters (HTTPArchive#983)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* REM units for page.css for eBook (HTTPArchive#979)

* REM units for page.css for eBook

* Add back in code-block divider even though currently not used

* Linter fixes

* Generate Chapters (HTTPArchive#987)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* add image

* French translation of the temp 2020 landing page (HTTPArchive#992)

* French translation of the temp 2020 landing page

As per HTTPArchive#969

* Update src/templates/fr/2020/index.html

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Update src/templates/fr/2020/index.html

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Update src/templates/fr/2020/index.html

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Generate Chapters (HTTPArchive#994)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix typo (HTTPArchive#993)

* Generate Chapters (HTTPArchive#995)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Automate chapter progress monitoring (HTTPArchive#990)

* Add alt="" for the decorative images. HTTPArchive#439

* Consistent titles and subtitles. HTTPArchive#439

* generate

* Add mising bold font (HTTPArchive#632)

* Add Workflow to track chapter progress

* Change config constants all caps

* Keep unfinished tasks empty in the grid

* Parse known links and add draft link

* Add columns for Links and Team

* Skip issues with zero or unexpected number of tasks

* Update workflow trigger logic

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Add logging for debugging corner cases

* Use correct terminology as issue number not id

* Update control flow to skip invalid tasks

* Use issue update as trigger with label filter

* Prevent manual trigger from being skipped

* Parametrize number of tasks and simply control flow

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Parse TOTAL_TRACKED_TASKS environment variable as integer

* Update icon for draft link

* Remove debug message that is no longer relevant

* Add more dubugging messages to show the progress

* Exclude links as the base SQL dir

Co-authored-by: Catalin Rosu <redmaniack@gmail.com>
Co-authored-by: Rick Viscomi <rviscomi@gmail.com>
Co-authored-by: Barry <barry@tunetheweb.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Translation of index.html to Japanese (HTTPArchive#996)

* Generate Chapters (HTTPArchive#999)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Misc cleanups for 2020 landing page (HTTPArchive#1000)

* Correct Compression Featured Chapter quote (HTTPArchive#1001)

* Add feature-policy (HTTPArchive#1003)

* Add feature-policy

* Add newline

* Add Dependabot Update config for automated dependency updates (HTTPArchive#1004)

* Add alt="" for the decorative images. HTTPArchive#439

* Consistent titles and subtitles. HTTPArchive#439

* generate

* Add mising bold font (HTTPArchive#632)

* Add dependabot update config

Co-authored-by: Catalin Rosu <redmaniack@gmail.com>
Co-authored-by: Rick Viscomi <rviscomi@gmail.com>
Co-authored-by: Barry <barry@tunetheweb.com>

* Misc fixes in preparation of adding HTML Linter (HTTPArchive#997)

* Misc updates in preparation of adding HTML Linter

* Consistent quotes

* Extra <li>

* Fix option code to pass linter

* Fix bios to pass linter

* Generate Chapters (HTTPArchive#1007)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Bump jsdom from 16.2.2 to 16.3.0 in /src (HTTPArchive#1006)

Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.2.2 to 16.3.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](jsdom/jsdom@16.2.2...16.3.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Translation of Compression chapter(2019) to French  (HTTPArchive#977)

* create files

* pass 1 / mid file

* translation 2

* translation HTTPArchive#3

* WIP

* WIP

* Boris' review

* update compression translation

* rebase from alamanac

* update and translate templates

* update &nbsp;%

* Update

* update templates/fr/2019/featured_chapters.html

* typo Huffman

Co-authored-by: Boris SCHAPIRA <borisschapira@gmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>

* Generate Chapters (HTTPArchive#1009)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix compression (HTTPArchive#1011)

* Fix featured chapters japanese translation (HTTPArchive#1012)

* fix compression

* fix mistake translate

* Compression featured quote HTTPArchive#1002 (HTTPArchive#1014)

* Pin versions (including older version for flask) (HTTPArchive#1008)

* Add HTML Linter (HTTPArchive#998)

* Fix typo in README (HTTPArchive#1017)

* Add unique id for each section to enable enhanced link tracking (HTTPArchive#1018)

* Add unique id for each section to enable enhanced link tracking

* Add 2020 home page

* Add GA config

* Add some more ids to ensure each link is within 3 levels

* Remove inline styles from CSP (HTTPArchive#1010)

* Bump flask from 1.1.1 to 1.1.2 in /src (HTTPArchive#1022)

Bumps [flask](https://github.com/pallets/flask) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/master/CHANGES.rst)
- [Commits](pallets/flask@1.1.1...1.1.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Compress base images again (HTTPArchive#1019)

* Compress images even more

* Removed incorrectly sized apple image

* Bump pytest from 4.6.11 to 5.4.3 in /src (HTTPArchive#1023)

Bumps [pytest](https://github.com/pytest-dev/pytest) from 4.6.11 to 5.4.3.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@4.6.11...5.4.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 2020 contributors (HTTPArchive#1024)

* initial batch of 2020 contributors (authors)

* Add Leaders and Languages

* Revert year config as doesn't work

* Add Twitter handles

* Remaining contributors

* Extra couple of contributors

* Leaders -> Leads

* Remove escaped slash from 2019 config for readability

* Review feedback

* Add matuzo

Co-authored-by: Rick Viscomi <rviscomi@gmail.com>

* Generate Chapters (HTTPArchive#1028)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate non-chapter pages in Sitemap based on JSON config (HTTPArchive#1027)

* Generate non-chapter pages based on JSON config

* Regenerate to include Contributors

* CSP for Sitemap (HTTPArchive#1029)

* Sitemap CSP fix - take 2 (HTTPArchive#1030)

* CSP for Sitemap

* Proper fix for Sitemap CSP

* Updated contributor info (HTTPArchive#1031)

* Updated contributor info

Added paulcavano's website link.

* Update 2019.json

* Fix bad padding (HTTPArchive#1034)

* Generate Chapters (HTTPArchive#1035)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Bad padding (HTTPArchive#1036)

* Fix bad padding

* Another padding fix

* Generate Chapters (HTTPArchive#1037)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add dimensions to Home Page Hero Image (HTTPArchive#1038)

* Show team members in the tooltip (HTTPArchive#1041)

* Refactor username parsing

* Remove unnecessary exclusion

* Show team mebers in the tooltip

* Reorganise HEAD to load CSS as quickly as possible (HTTPArchive#1039)

* Reorganise HEAD to load CSS as quickly as possible

* Remove unnecessary nonce

* Move contribution info to own file (HTTPArchive#1046)

* Create CONTRIBUTING.md

* Update README.md

* Fix bug where code block causes scrolling issues on mobile (HTTPArchive#1050)

* Generate Chapters (HTTPArchive#1051)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* 2020 Config Updates (HTTPArchive#1048)

* 2020 Config Updates

* Add two more analysts

* Add some more people

* Latest chapter order

* Missing comma

* Add line breaks

* Revert "Add line breaks"

This reverts commit 51fbd48.

* CSS newline linter (HTTPArchive#1053)

* Test newline linting

* Add newlines

* Missed some newlines

* Missed new line

* Reset Action back to normal

* Generate Chapters (HTTPArchive#1054)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Make Contributor buttons accessible (HTTPArchive#1042)

* Make Contributor buttons accessible

* Fix duplication of filter by block

* Change to unpressed by default

* Update src/templates/base/2019/contributors.html

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Order by Team Translation

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Generate Chapters (HTTPArchive#1055)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix bug where code block causes scrolling issues on mobile - repeat (HTTPArchive#1056)

* Fix bug where code block causes scrolling issues on mobile

* Add newline for linter

* Generate Chapters (HTTPArchive#1057)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Refactoring, sorting, and enhancing progress report (HTTPArchive#1059)

* Sort by chapter number and refactor

* Add legend and footnote

* Move legend to column tooltip

* Report team members and their chapters

* Read tracked tasks from the reporting issue

* Change delimiter

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* Prevent auto-mention for team members

* Show contributors list only on demand

* Add function to calculate statistics

* Report chapter contributor statistics

* Change summary text and make it bold

Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>

* fix typo (HTTPArchive#1063)

5% -> 50%

* Generate Chapters (HTTPArchive#1065)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix contributor padding issues and wrap control in a form (HTTPArchive#1066)

* fix typo accessibility translation in Japanese (HTTPArchive#1064)

* Generate Chapters (HTTPArchive#1068)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Support hyphens in usernames and sort contributors by most to least chapters (HTTPArchive#1060)

* hyphens and sorting

* fix median

* feedback

* testing

fixed syntax errors after testing

* use "member" naming

* case insensitive secondary sort of member names

* Better printed ebook, including a cover (HTTPArchive#1069)

* Change to A5 size for printing

* Add cover

* Fix cover

* Remove unnecssary code

* Fix some rems

* Fix contributors and ass printer setting

* Better alignment of cover

* Finish cover

* Make ebook resizable

* Extra params

* More rem-based styles

* Linting issues

* Update README

* Regen ebooks

* Handle large images

* Merge cover and ebook into one template

* Fix bad padding

* Merge from main

* Add Japanese version

* Move title down on cover and simplify cover args

* Better ebook instructions

* Linting errors

* Review feedback

* Generate Chapters (HTTPArchive#1070)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add collective team in the progress report (HTTPArchive#1071)

* Report combined team size

* Refactor stats calculation

* Adjust tooltip as per new team formatting

* Add new team type in the initialization

* Change backticks to single quotes

* Make union of chapter contributors unique

* Update CONTRIBUTING.md

* Adding myself to the json :) (HTTPArchive#1075)

* Adding myself to the json :)

* moving to alphabetical place

* Update contributors (HTTPArchive#1077)

* update contributors

* img dimensions

* rm twitter from website

* Spanish translation of the temp 2020 landing page (HTTPArchive#1080)

* Translate index.html to Spanish

Left 'Web Almanac' like that as it is a noun. Happy to translate too if that's what has been done in other languages.

* Capitalize 'Web' when used as a noun.

* Add mcmd to 2020 contributors

* Generate Chapters (HTTPArchive#1081)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Tweak the contributors SVG and fix the scenario when the contributor-join block isn't full height. (HTTPArchive#1085)

Fixes HTTPArchive#1076

Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sakae Kotaro <ksakae1216@gmail.com>
Co-authored-by: Automatic Update <bazzadp@users.noreply.github.com>
Co-authored-by: Aymen Loukil <AymenLoukil@users.noreply.github.com>
Co-authored-by: Boris Schapira <borisschapira@gmail.com>
Co-authored-by: Barry <barry@tunetheweb.com>
Co-authored-by: Nicolas Hoffmann <dante3333@gmail.com>
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
Co-authored-by: Catalin Rosu <me@catalin.red>
Co-authored-by: Mike Geyser <mikegeyser@gmail.com>
Co-authored-by: Adam Demirel <adxm@msn.com>
Co-authored-by: Satya Kresna <satyakresna6295@gmail.com>
Co-authored-by: Sawood Alam <ibnesayeed@gmail.com>
Co-authored-by: Durga Prasad Sadhanala <dsadhanala@users.noreply.github.com>
Co-authored-by: Max Ostapenko <bvz2001@gmail.com>
Co-authored-by: Catalin Rosu <redmaniack@gmail.com>
Co-authored-by: Rick Viscomi <rviscomi@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Allemand Sébastien <sebastienallemand.as@gmail.com>
Co-authored-by: Mat Kelly <machawk1@gmail.com>
Co-authored-by: Paul Calvano <paulcalvano@yahoo.com>
Co-authored-by: r-yanyo <honma.ryosuke@gmail.com>
Co-authored-by: Soichi Masuda <masuP9@gmail.com>
Co-authored-by: Alex Tait <alexandratait@gmail.com>
Co-authored-by: mcmd <miguelcarlos.martinez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack performance Issues related to site performance
Projects
No open projects
2020
  
Done
Development

Successfully merging this pull request may close these issues.

Add Web Vitals to analytics
5 participants